Small Shashlik reco speed improvement

[mark-grimes]

@davidlange6 is this what you meant?

Functionally the same but the order of checks has been changed to improve speed. There is a minor side effect in that fewer debug printouts will occur when the previously-second "if" evaluates to false, so that the previously-first "if" (which would produce the printout) is skipped.
All plots are ttbar at 140 pileup in Shashlik; "before" plots include #4909.

Total event times before and after

This equates to a drop from 6.1+/-1.7 minutes to 5.9+/-1.8 minutes per event (mean+/-sqrt(variance)). Doesn't sound that impressive when stated like that, but they're the same events not random data.

User time by module before

User time by module after

Some modules appear to slightly increase in time (e.g. particleFlowTmp, particleFlowEGamma) but others significantly decrease (particleFlowBlock). I'm not sure how accurate the timing is so I suspect this is just noise.

Updated igprof file at /afs/cern.ch/user/g/grimes/public/SLHC16_patch1Preview/igreport_perf_ShashlikRecoAfterLangeSuggestion_15evt.res
@davidlange6, @lgray

[cmsbuild]

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Small Shashlik reco speed improvement

It involves the following packages:

RecoParticleFlow/PFClusterTools

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mark-grimes]

merge