Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator level heavy flavour jet origin/flavour identification #4934

Merged

Conversation

bartosik-hep
Copy link
Contributor

Original implementation of the code for finding flavour, origin and leptonic decay of heavi flavour hadrons/jets.
This implementation still uses a copy of GenJetParticles module to inject ghost hadrons into generator jets.
This could be replaced by an existing new implementation of jet flavour identification which already injects wide range of particles into jets. In order to use reclustered jets from jet flavour ID one would need to replace the input genJets collections in the PhysicsTools/JetMCAlgos/python/sequences/GenHFHadronMatching_cff.py sequences.

A very simple test config file has been added: PhysicsTools/JetMCAlgos/test/genHFHadronMatcher.py

It doesn't produce any input since this would need to write information into some ROOT file. It just checks whether the algorithm runs in the particular release.

This code has been tested to compile and run in CMSSW_7_1_6 release on lxplus0185.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bartosik-desy (Nazar Bartosik) for CMSSW_7_2_X.

Generator level heavy flavour jet origin/flavour identification

It involves the following packages:

PhysicsTools/JetMCAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@ferencek, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@bartosik-hep
Copy link
Contributor Author

It's also should be kept in mind that the current default genJets input collection as it is set in PhysicsTools/JetMCAlgos/python/GenHFHadronMatcher_cfi.py is set to cms.InputTag('ak5GenJets','','SIM')

And then in PhysicsTools/JetMCAlgos/python/sequences/GenHFHadronMatching_cff.py reclustering of jets is done again with ak5GenJetsPlusCHadron = ak5GenJets.clone()
I think it should be changed to ak4GenJets for CMSSW_7_X releases in future if it is going to be the standard.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor


const unsigned int nJets = genJets.size();
int topDaughterQId = -1;
int topBarDaughterQId= -1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nazar
I am trying to understand the code. I am sorry I missed it.
These two variables are changed somewhere?

…ronMatcher to allow direct check of its output
@monttj
Copy link
Contributor

monttj commented Aug 25, 2014

+1
I am sorry I was too quick.
I see now the update.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Aug 25, 2014
…HadronOrigin

Generator level heavy flavour jet origin/flavour identification
@ktf ktf merged commit e3ba21b into cms-sw:CMSSW_7_2_X Aug 25, 2014
@cmsbuild
Copy link
Contributor

@bartosik-hep
Copy link
Contributor Author

Dear @vadler @monttj @cmsbuild , I have committed the latest version of the GenHFHadronMatcher tool to the same branch CMSSW_7_1_X_AT_genHFHadronOrigin. The new version is using the official JetFlavour Identification tool for hadron-jet matching and has some issues with Pythia8 solved. What should be done in addition to have this latest version in the CMSSW_7_3_X?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants