Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLHC conversion of ecal and hcal reco geometry to TGeo format #5046

Merged
merged 3 commits into from Sep 2, 2014

Conversation

alja
Copy link
Contributor

@alja alja commented Aug 25, 2014

Port changes from 7x branch.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_6_2_X_SLHC.

Conversion of ecal and hcal reco geometry to TGeo format

It involves the following packages:

Fireworks/Core
Fireworks/Geometry

@Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja alja changed the title Conversion of ecal and hcal reco geometry to TGeo format SLHC conversion of ecal and hcal reco geometry to TGeo format Aug 25, 2014
@alja
Copy link
Contributor Author

alja commented Aug 25, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Sep 2, 2014
SLHC conversion of ecal and hcal reco geometry to TGeo format
@cmsbuild cmsbuild merged commit 1e6d189 into cms-sw:CMSSW_6_2_X_SLHC Sep 2, 2014
@alja alja deleted the slhc-tgeo-port branch May 11, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants