Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DQMFileSaver to use LogAbsolute instead of std::cout. #5059

Merged
merged 2 commits into from Aug 26, 2014

Conversation

dmitrijus
Copy link
Contributor

This should not produce garbled up messages when running multithread.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_2_X.

Migrate DQMFileSaver to use LogAbsolute instead of std::cout.

It involves the following packages:

DQMServices/Components

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@@ -112,13 +112,14 @@ DQMFileSaver::saveForOffline(const std::string &workflow, int run, int lumi) con
{
std::vector<std::string> systems = (dbe_->cd(), dbe_->getSubdirs());

std::cout << " DQMFileSaver: storing EventInfo folders for Run: "
edm::LogAbsolute("fileAction") << " DQMFileSaver: storing EventInfo folders for Run: "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this leaves an unnecessary extra space at the beginning of the line

@cmsbuild
Copy link
Contributor

@dmitrijus
Copy link
Contributor Author

Thanks for the notes, it should be better now.
But please test them. This, however, changes the point in time the log is outputted.

@cmsbuild
Copy link
Contributor

Pull request #5059 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Aug 26, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

davidlange6 added a commit that referenced this pull request Aug 26, 2014
Migrate DQMFileSaver to use LogAbsolute instead of std::cout.
@davidlange6 davidlange6 merged commit 33ffa7d into cms-sw:CMSSW_7_2_X Aug 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants