New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate DQMFileSaver to use LogAbsolute instead of std::cout. #5059
Conversation
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_2_X. Migrate DQMFileSaver to use LogAbsolute instead of std::cout. It involves the following packages: DQMServices/Components @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks. |
@@ -112,13 +112,14 @@ DQMFileSaver::saveForOffline(const std::string &workflow, int run, int lumi) con | |||
{ | |||
std::vector<std::string> systems = (dbe_->cd(), dbe_->getSubdirs()); | |||
|
|||
std::cout << " DQMFileSaver: storing EventInfo folders for Run: " | |||
edm::LogAbsolute("fileAction") << " DQMFileSaver: storing EventInfo folders for Run: " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this leaves an unnecessary extra space at the beginning of the line
Thanks for the notes, it should be better now. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
Migrate DQMFileSaver to use LogAbsolute instead of std::cout.
This should not produce garbled up messages when running multithread.