Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for number of secondary vertex tracks in case IVF vertices are used #5085

Merged
merged 1 commit into from Sep 6, 2014

Conversation

pvmulder
Copy link
Contributor

This fix does not affect the any b-tagger in the RECO sequence, it only affects the performance when IVF is used and even in that case the performance is very similar, as can be seen in the figure.
performance_clean

@slava77
Copy link
Contributor

slava77 commented Aug 28, 2014

@cmsbuild please get this on a regular list of PRs with labels, milestones and such

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pvmulder (Petra Van Mulders) for CMSSW_7_0_X.

fix for number of secondary vertex tracks in case IVF vertices are used

It involves the following packages:

RecoBTag/SecondaryVertex

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ferencek this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 5, 2014

+1

for #5085 84bc6b8
(the code doesn't run in standard seqs)
changes are consistent with what's done in #5160

(tested in CMSSW_7_0_8 test area sign709b)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 6, 2014
fix for number of secondary vertex tracks in case IVF vertices are used
@davidlange6 davidlange6 merged commit bafc70a into cms-sw:CMSSW_7_0_X Sep 6, 2014
@ferencek ferencek deleted the FixSVIVFtracks_70X branch September 18, 2014 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants