Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

same as https://github.com/cms-sw/cmssw/pull/5060, but starting form last nightly.... #5089

Merged

Conversation

degrutto
Copy link
Contributor

same as #5060, but starting form last nightly....

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @degrutto (michele de gruttola) for CMSSW_7_2_X.

same as #5060, but starting form last nightly....

It involves the following packages:

L1Trigger/CSCTrackFinder

@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mulhearn
Copy link
Contributor

Just curious: changes to firmware are accomodated by just making a new core_X directory? What happens if those 1024 line data files change (LUTs?)... that is just a new firmware version?

@mulhearn
Copy link
Contributor

+1

@degrutto
Copy link
Contributor Author

the new core directory is needed to emulate what has been changed to the firmware in hardware. There is a standard fpga to cpp converter used here. The other changes in the classes are needed to make sure one used the new additional information from new added CSC chambers/electronics (as the firmware is internally doing)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Aug 29, 2014
…8-0200

L1Trigger/CSCTrackFinder -- adapt new-CSCTF_250714 (62X_SLHC) to 72X
@nclopezo nclopezo merged commit e71a186 into cms-sw:CMSSW_7_2_X Aug 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants