Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port GEM software from 62XSLHC to 72X #5115

Merged
merged 190 commits into from Sep 12, 2014
Merged

Port GEM software from 62XSLHC to 72X #5115

merged 190 commits into from Sep 12, 2014

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Aug 30, 2014

Hi,

As a first step to port the GEM software from 62XSLHC to 72X I started from (*) and listed all geometry-related commits. I ignored all non-GEM commits and commits that were simply merges. I solved most conflicts manually. The resulting code compiles, but I have not been able to test it yet. Which workflow can I use to test it?

EDIT: fixed various suggestions by Slava
EDIT2: include the frame rotation fixes in SimG4CMS/Muon
EDIT3: include ME0DigiPreReco dataformat from DataFormats/GEMDigi
EDIT4: update the digitizers in SimMuon/GEMDigitizer
EDIT5: update of the inclusion guards in various GEM and related header files
EDIT6: Minor fixes following suggestions by @slava77 , @civanch and @ianna

Cheers,
Sven

(*)

commits=( $(git log --topo-order official-cmssw/CMSSW_6_2_X..official-cmssw/CMSSW_6_2_X_SLHC --reverse --pretty=format:%h -- Geometry/GEMGeometry Geometry/GEMGeometryBuilder Geometry/GlobalTrackingGeometryBuilder Geometry/CommonDetUnit Geometry/Records DataFormats/MuonDetId Geometry/MuonNumbering CondTools/Geometry) )

@civanch
Copy link
Contributor

civanch commented Sep 11, 2014

@dildick, I would suggest if possible any specific upgrade, which change somehow code for 2015 to be included into separate PR(s) which should be discussed at simulation meeting. From this PR we may require that the code is integrated and does not disturb mainstream. In the next PR(s) you may achieve desired physics performance.

@civanch
Copy link
Contributor

civanch commented Sep 11, 2014

+1

@dildick
Copy link
Contributor Author

dildick commented Sep 11, 2014

@civanch Okay, sounds good. That's all then for this PR.

@davidlange6
Copy link
Contributor

Reco already signed off - so merging - complain if not ok

davidlange6 added a commit that referenced this pull request Sep 12, 2014
Port GEM software from 62XSLHC to 72X
@davidlange6 davidlange6 merged commit 2c423ec into cms-sw:CMSSW_7_2_X Sep 12, 2014
@dildick dildick deleted the GEM-72X branch April 30, 2016 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet