Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused data member #5200

Merged
merged 2 commits into from Sep 8, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Sep 5, 2014

The type_ data member of classes typeBases, TypeDataMembers, and TypeFunctionMembers is no longer used. Remove it.
Also, the function TypeWithDict::setProperty() is unused. Remove it also.
Please merge this techinical trivial ROOT6 specific pull request as soon as convenient.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

A new Pull Request was created by @wmtan for CMSSW_7_2_ROOT6_X.

Remove unused data member

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

Pull request #5200 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_ROOT6_X IBs unless changes or unless it breaks tests.

@wmtan
Copy link
Contributor Author

wmtan commented Sep 8, 2014

Can this be merged? It's been sitting here for three days.

davidlt added a commit that referenced this pull request Sep 8, 2014
@davidlt davidlt merged commit 2067ec5 into cms-sw:CMSSW_7_2_ROOT6_X Sep 8, 2014
@wmtan wmtan deleted the RemoveUnusedDataMember branch September 9, 2014 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants