Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to match new Wrapper constructor API #5203

Merged
merged 1 commit into from Sep 6, 2014

Conversation

Dr15Jones
Copy link
Contributor

The Wrapper class switch from using a std::auto_ptr to a std::unique_ptr.
This code was missed in the first pass of updating all code to use the
new API.

The Wrapper class switch from using a std::auto_ptr to a std::unique_ptr.
This code was missed in the first pass of updating all code to use the
new API.
@Dr15Jones
Copy link
Contributor Author

@ktf @davidlange6 This pull request fixes the compilation problem in the 2014-09-06-1400 build

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Update code to match new Wrapper constructor API

It involves the following packages:

EventFilter/Utilities
GeneratorInterface/LHEInterface

@vciulli, @nclopezo, @emeschi, @thuer, @cmsbuild, @bendavid, @mommsen can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@emeschi
Copy link
Contributor

emeschi commented Sep 6, 2014

+1

@davidlange6
Copy link
Contributor

whoops - I missed this… Great. Thanks
On Sep 6, 2014, at 7:01 PM, Chris Jones notifications@github.com
wrote:

@ktf @davidlange6 This pull request fixes the compilation problem in the 2014-09-06-1400 build


Reply to this email directly or view it on GitHub.

davidlange6 added a commit that referenced this pull request Sep 6, 2014
Update code to match new Wrapper constructor API
@davidlange6 davidlange6 merged commit b273ecf into cms-sw:CMSSW_7_2_X Sep 6, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2014

@Dr15Jones Dr15Jones deleted the updateToNewWrapperAPI branch September 8, 2014 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants