Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve undefined behavior with VLAs length #5424

Merged
merged 1 commit into from Sep 23, 2014

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Sep 18, 2014

RecoEcal/EgammaClusterAlgos/src/Multi5x5BremRecoveryClusterAlgo.cc:47:34:
runtime error: variable length array bound evaluates to non-positive
value 0
RecoEcal/EgammaClusterAlgos/src/Multi5x5BremRecoveryClusterAlgo.cc:50:30:
runtime error: variable length array bound evaluates to non-positive
value 0

Multi5x5BremRecoveryClusterAlgo::makeIslandSuperClusters(..) is called
with empty clusters_v. There is nothing to be done if clusters_v is
empty, thus bail out early.

This happens 36 times while running short matrix.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

RecoEcal/EgammaClusterAlgos/src/Multi5x5BremRecoveryClusterAlgo.cc:47:34:
runtime error: variable length array bound evaluates to non-positive
value 0
RecoEcal/EgammaClusterAlgos/src/Multi5x5BremRecoveryClusterAlgo.cc:50:30:
runtime error: variable length array bound evaluates to non-positive
value 0

Multi5x5BremRecoveryClusterAlgo::makeIslandSuperClusters(..) is called
with empty clusters_v. There is nothing to be done if clusters_v is
empty, thus bail out early.

This happens 36 times while running short matrix.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_2_X.

Resolve undefined behavior with VLAs length

It involves the following packages:

RecoEcal/EgammaClusterAlgos

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@argiro, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlt
Copy link
Contributor Author

davidlt commented Sep 19, 2014

I had finished running a full matrix now, this was triggered 1344 times, i.e. calling a function with clusters_v being empty.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please test (maybe if something is in the queue already there could be an automatic message here)

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
Tested 2770647 on top of CMSSW_7_2_X_2014-09-18-1400.
Ran Short matrix tests + wf 202 and 25202 (ttbar), all fine. No diffs in FWLite and DQM comparison plots. The PR is a trivial bug fix (empty cluster collections avoided).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@davidlt
Copy link
Contributor Author

davidlt commented Sep 19, 2014

@StoyanStoynev you should be able to see the queue here: https://cmssdt.cern.ch/jenkins/job/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/ (the link is self describing)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 23, 2014
Resolve undefined behavior with VLAs length
@davidlange6 davidlange6 merged commit 6b8d74a into cms-sw:CMSSW_7_2_X Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants