New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve undefined behavior with VLAs length #5424
Conversation
RecoEcal/EgammaClusterAlgos/src/Multi5x5BremRecoveryClusterAlgo.cc:47:34: runtime error: variable length array bound evaluates to non-positive value 0 RecoEcal/EgammaClusterAlgos/src/Multi5x5BremRecoveryClusterAlgo.cc:50:30: runtime error: variable length array bound evaluates to non-positive value 0 Multi5x5BremRecoveryClusterAlgo::makeIslandSuperClusters(..) is called with empty clusters_v. There is nothing to be done if clusters_v is empty, thus bail out early. This happens 36 times while running short matrix. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_7_2_X. Resolve undefined behavior with VLAs length It involves the following packages: RecoEcal/EgammaClusterAlgos @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
I had finished running a full matrix now, this was triggered 1344 times, i.e. calling a function with |
@cmsbuild please test (maybe if something is in the queue already there could be an automatic message here) |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
@StoyanStoynev you should be able to see the queue here: https://cmssdt.cern.ch/jenkins/job/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/ (the link is self describing) |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
Resolve undefined behavior with VLAs length
Multi5x5BremRecoveryClusterAlgo::makeIslandSuperClusters(..)
is calledwith empty
clusters_v
. There is nothing to be done ifclusters_v
isempty, thus bail out early.
This happens 36 times while running short matrix.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch