Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added combinedMVABJetTags and removed combinedSecondaryVertexMVABJetTags from reco sequence, added bugfix for pfTagInfos, updated PAT/miniAOD configs: Forward port from 7_2_X to 7_3_X #5449

Conversation

ferencek
Copy link
Contributor

Forward port of #5446

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_3_X.

Updated default PAT jet btag discriminators: Forward port from 7_2_X to 7_3_X

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@nhanvtran, @TaiSakuma, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1

Tested at: 2577dd9
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5449/34/summary.html

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
Tested 4b97fc6 on top of CMSSW_7_3_X_2014-09-27-1400. All short matrix tests pass and (expected) differences are as in #5446 - the two PRs are identical, just for different releases (the current PR is a forward port). See the review for #5446 .

@deguio
Copy link
Contributor

deguio commented Sep 28, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Sep 29, 2014
…ate_from-CMSSW_7_2_0_pre6

Added combinedMVABJetTags and removed combinedSecondaryVertexMVABJetTags from reco sequence, added bugfix for pfTagInfos, updated PAT/miniAOD configs: Forward port from 7_2_X to 7_3_X
@nclopezo nclopezo merged commit c41466c into cms-sw:CMSSW_7_3_X Sep 29, 2014
@ferencek ferencek deleted the PATJetBTagDiscriminatorsUpdate_from-CMSSW_7_2_0_pre6 branch September 30, 2014 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants