Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beamspot nominal collision2015: set new default #5464

Merged
merged 3 commits into from Sep 23, 2014
Merged

Beamspot nominal collision2015: set new default #5464

merged 3 commits into from Sep 23, 2014

Conversation

franzoni
Copy link

  • introduce beamspot parameters as agreed during PPD General discussion https://indico.cern.ch/event/341218/ , NominalCollision2015
  • the defaualt beamspot (used by ConfigBuilder if no option is specified) is updated to be NominalCollision2015
  • use the NominalCollision2015 for postLs1 relvals, keep Realistic8TeVCollision in runI relvals

Giovanni Franzoni added 3 commits September 22, 2014 11:04
@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Sep 22, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_7_3_X.

Beamspot nominal collision2015: set new default

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
IOMC/EventVertexGenerators

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @cerati, @GiacomoSguazzoni, @rovere, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@franzoni
Copy link
Author

+1

@civanch
Copy link
Contributor

civanch commented Sep 22, 2014

+1

@davidlange6
Copy link
Contributor

normally this change will not give good results until the reco BS is updated. Is there some reason to expect things won't be broken this time around?

@cmsbuild
Copy link
Contributor

+1
Tested at: 7c39667
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5464/47/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5464/47/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Sep 23, 2014
@ktf
Merge pull request #5464 from franzoni/beamspot_NominalCollision2015-…
397b643 
…CMSSW_7_3_X_2014-09-22-0200

Beamspot nominal collision2015: set new default
@ktf ktf merged commit 397b643 into cms-sw:CMSSW_7_3_X Sep 23, 2014
@davidlange6
Copy link
Contributor

we aren't ready for this, afaik. Backing out

@davidlange6 davidlange6 mentioned this pull request Sep 23, 2014
Merged
@franzoni franzoni mentioned this pull request Sep 24, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed operations-approved simulation-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@franzoni @cmsbuild @civanch @davidlange6 @ktf