Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash of GenParticles2HepMCConverter #5533

Merged
merged 1 commit into from Sep 25, 2014

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Sep 24, 2014

Same for #5532

The GenParticles2HepMCConverter can crash if a particle's pdgId is not present in the HepPDT while setting the generated_mass.
The problem was spotted by Bhawan.
Query to get particle info with pdgId=102112 returns null pointer, causes segmentation fault.

As a solution, particle's generated_mass in HepMC is assigned to be same as the GenParticle's mass itself if it fails to get particle from PDT.
This is safe for the Rivet analysis since this information shouldn't be used in the particle level analysis.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_3_X.

Avoid crash of GenParticles2HepMCConverter

It involves the following packages:

GeneratorInterface/RivetInterface

@vciulli, @cmsbuild, @nclopezo, @bendavid, @thuer can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 25, 2014
 Avoid crash of GenParticles2HepMCConverter
@davidlange6 davidlange6 merged commit 833fc9c into cms-sw:CMSSW_7_3_X Sep 25, 2014
@cmsbuild
Copy link
Contributor

@jhgoh jhgoh deleted the AvoidCrashRivetAODSIM branch October 11, 2014 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants