Avoid crash of GenParticles2HepMCConverter #5533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same for #5532
The GenParticles2HepMCConverter can crash if a particle's pdgId is not present in the HepPDT while setting the generated_mass.
The problem was spotted by Bhawan.
Query to get particle info with pdgId=102112 returns null pointer, causes segmentation fault.
As a solution, particle's generated_mass in HepMC is assigned to be same as the GenParticle's mass itself if it fails to get particle from PDT.
This is safe for the Rivet analysis since this information shouldn't be used in the particle level analysis.