Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pythia8.200pre2 interface changes #5551

Merged
2 commits merged into from Sep 25, 2014
Merged

Pythia8.200pre2 interface changes #5551

2 commits merged into from Sep 25, 2014

Conversation

bendavid
Copy link
Contributor

Required interface changes to go along with
cms-sw/cmsdist#1054
(must go in simultaneously)

@bendavid
Revert "Merge pull request cms-sw#5475 from cms-sw/revert-5436-topyth…
25fed53 
…ia8200pre1_73"

This is the revert of the revert of the pythia 8.2 interface changes.

This reverts commit 9752db5, reversing
changes made to 3b1c7de.
@bendavid
Move to pythia8 internal jet matching code and remove cms copy. Remov…
440ed79 
…e no-longer-needed workaround for slha header and pass it properly through pythia8 lhe interface
@bendavid bendavid mentioned this pull request Sep 24, 2014
Merged
@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Sep 24, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_3_X.

Pythia8.200pre2 interface changes

It involves the following packages:

FastSimulation/ParticleDecay
GeneratorInterface/PartonShowerVeto
GeneratorInterface/Pythia8Interface

@vciulli, @civanch, @nclopezo, @lveldere, @mdhildreth, @cmsbuild, @thuer, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor Author

+1

@lveldere
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@ghost
Copy link

ghost commented Sep 25, 2014

+1
Tested locally against cms-sw/cmsdist#1054. Ran usual matrix workflows:
1306.0,101.0,1003.0,50101.0,9.0,25202.0
No test failed.

ghost pushed a commit that referenced this pull request Sep 25, 2014
@aledegano
Merge pull request #5551 from bendavid/pythia8200pre2interface
18d7a49 
Pythia8.200pre2 interface changes
@ghost ghost merged commit 18d7a49 into cms-sw:CMSSW_7_3_X Sep 25, 2014
@bendavid
Copy link
Contributor Author

Will this make it for 1400 IB?

@ktf
Copy link
Contributor

ktf commented Sep 25, 2014

yes.

bendavid pushed a commit to bendavid/cmssw that referenced this pull request Sep 28, 2014
@aledegano @bendavid
Merge pull request cms-sw#5551 from bendavid/pythia8200pre2interface
0289d26 
Pythia8.200pre2 interface changes
Conflicts:
	FastSimulation/ParticleDecay/interface/PythiaDecays.h
	FastSimulation/ParticleDecay/src/PythiaDecays.cc
bendavid pushed a commit to bendavid/cmssw that referenced this pull request Sep 28, 2014
@aledegano @bendavid
Merge pull request cms-sw#5551 from bendavid/pythia8200pre2interface
be7097e 
Pythia8.200pre2 interface changes
bendavid pushed a commit to bendavid/cmssw that referenced this pull request Sep 28, 2014
@aledegano @bendavid
Merge pull request cms-sw#5551 from bendavid/pythia8200pre2interface
93b5300 
Pythia8.200pre2 interface changes
Conflicts:
	FastSimulation/ParticleDecay/src/PythiaDecays.cc
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fastsim-approved fully-signed generators-approved tests-pending
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bendavid @cmsbuild @lveldere @ktf