Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch pileup to 35 for relvals #5591

Conversation

franzoni
Copy link

switch pileup to 35 for relvals, both 25ns and 50sn; as agreed here: https://indico.cern.ch/event/342011/

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_7_3_X.

switch pileup to 35 for relvals

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @davidlange6, @franzoni, @nclopezo, @vlimant can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@franzoni
Copy link
Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1

Tested at: 858db28
I ran the usual tests and I found errors in the following unit tests:

---> test testDataFormatsFWLite had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5591/85/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@franzoni
Copy link
Author

franzoni commented Oct 6, 2014

Hello, I suspect that the test failing with testDataFormatsFWLite does not originate from this PR. The local tests I run on top of CMSSW_7_3_X_2014-09-26-0800 did not show that error. Did the issue relarted to testDataFormatsFWLite arise in relation to any other PR ? If so, could the tests be re-triggered, please ?
Cheers, G.

@franzoni
Copy link
Author

franzoni commented Oct 7, 2014

Any news on this PR ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

nclopezo added a commit that referenced this pull request Oct 8, 2014
…X_2014-09-26-0800

Configuration/PyReleaseValidation -- switch pileup to 35 for relvals
@nclopezo nclopezo merged commit 5ed993e into cms-sw:CMSSW_7_3_X Oct 8, 2014
@franzoni
Copy link
Author

franzoni commented Oct 9, 2014

cool, thanks for this.
Impact on the IB turn-around time ?
12 workflows should now take a factor up-to-six longer to complete the DIGI-RECO step. That should be a ~negligible amount of extra time, when the full matrix is run for IB.
Cheers, G.

@ktf
Copy link
Contributor

ktf commented Oct 14, 2014

I do not see any particularly big difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants