Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IB addOn tests #5605

Merged
merged 2 commits into from Sep 29, 2014
Merged

Fix IB addOn tests #5605

merged 2 commits into from Sep 29, 2014

Conversation

Martin-Grunewald
Copy link
Contributor

Fix IB addOn tests from #5530 fallout.

@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 29, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_2_X.

Fix IB addOn tests

It involves the following packages:

FastSimulation/Configuration
Utilities/ReleaseScripts

@civanch, @Dr15Jones, @lveldere, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor

+1

@lveldere
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

+1
Tested at: f929482
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5605/1095/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5605/1095/summary.html

davidlange6 added a commit that referenced this pull request Sep 29, 2014
@davidlange6
Merge pull request #5605 from Martin-Grunewald/FixAddOnTests
b8c55e1 
Fix IB addOn tests
@davidlange6 davidlange6 merged commit b8c55e1 into cms-sw:CMSSW_7_2_X Sep 29, 2014
@Martin-Grunewald Martin-Grunewald deleted the FixAddOnTests branch September 30, 2014 04:48
@Martin-Grunewald Martin-Grunewald mentioned this pull request Oct 3, 2014
Merged
@perrotta perrotta mentioned this pull request Oct 3, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-pending fastsim-approved orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Martin-Grunewald @cmsbuild @lveldere @davidlange6