New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of GenLumiInfoProduct and associated cross section machinery to 53x #5617
Conversation
Codes require to save generator cross section in each luminosity block
GeneratorInterface -- Codes that fix the cross section computation
A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_5_3_X. Backport of GenLumiInfoProduct and associated cross section machinery to 53x It involves the following packages: GeneratorInterface/Configuration @vciulli, @cmsbuild, @nclopezo, @bendavid, @thuer can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it? |
-1 Will add the appropriate fix here as well. |
+1 |
@@ -38,8 +38,7 @@ class GenFilterEfficiencyAnalyzer : public edm::EDAnalyzer { | |||
virtual void endLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&); | |||
virtual void endJob(); | |||
|
|||
int nTota_; | |||
int nPass_; | |||
GenFilterInfo totalGenFilterInfo_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this analyzer be changed to a edm::one::EDAnalyzer to improve threaded efficiency?
Please consider changing all the modules from legacy types to the thread efficient types. |
This is the 53x pull request, so no. In the 7x series yes. This module as you can see does nothing in the event loop (is leaving an empty analyze function the optimal thing here?) Then all of the work is done in endLuminosityBlock and endJob, what would be most appropriate threaded type and template parameters for this? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it? |
+tested |
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). @smuzaffar can you please take care of it? |
Backport of GenLumiInfoProduct and associated cross section machinery to 53x
Needed to be able to compute correct cross sections for weighted samples (eg. NLO FXFX-merged) without heavy/slow interactive running.