Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of GenLumiInfoProduct and associated cross section machinery to 53x #5617

Merged
merged 5 commits into from Oct 3, 2014

Conversation

bendavid
Copy link
Contributor

Needed to be able to compute correct cross sections for weighted samples (eg. NLO FXFX-merged) without heavy/slow interactive running.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_5_3_X.

Backport of GenLumiInfoProduct and associated cross section machinery to 53x

It involves the following packages:

GeneratorInterface/Configuration
GeneratorInterface/Core
GeneratorInterface/LHEInterface
SimDataFormats/GeneratorProducts

@vciulli, @cmsbuild, @nclopezo, @bendavid, @thuer can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@bendavid
Copy link
Contributor Author

-1
This will fail with the same problem as in 73x (since it also includes the last update to the sequence)

Will add the appropriate fix here as well.

@bendavid
Copy link
Contributor Author

+1
Fixed now as in 73x

@@ -38,8 +38,7 @@ class GenFilterEfficiencyAnalyzer : public edm::EDAnalyzer {
virtual void endLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&);
virtual void endJob();

int nTota_;
int nPass_;
GenFilterInfo totalGenFilterInfo_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this analyzer be changed to a edm::one::EDAnalyzer to improve threaded efficiency?

@Dr15Jones
Copy link
Contributor

Please consider changing all the modules from legacy types to the thread efficient types.

@bendavid
Copy link
Contributor Author

This is the 53x pull request, so no. In the 7x series yes.

This module as you can see does nothing in the event loop (is leaving an empty analyze function the optimal thing here?)

Then all of the work is done in endLuminosityBlock and endJob, what would be most appropriate threaded type and template parameters for this?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@smuzaffar
Copy link
Contributor

+tested

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). @smuzaffar can you please take care of it?

davidlange6 added a commit that referenced this pull request Oct 3, 2014
Backport of GenLumiInfoProduct and associated cross section machinery to 53x
@davidlange6 davidlange6 merged commit a6f0f2c into cms-sw:CMSSW_5_3_X Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants