Use TClass::GetClass(), not gROOT->GetClass() #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_3_X. Use TClass::GetClass(), not gROOT->GetClass() It involves the following packages: DataFormats/Common @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
cmsbuild
added
comparison-pending
core-approved
fully-signed
tests-approved
and removed
comparison-pending
core-approved
fully-signed
tests-pending
labels
cmsbuild
added
comparison-available
core-approved
fully-signed
tests-approved
and removed
fully-signed
tests-approved
labels
nclopezo
added a commit
that referenced
this pull request
Oct 1, 2014
Use TClass::GetClass(), not gROOT->GetClass()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial technical change. It is being requested for standardization, and for code commonality with the ROOT6 7_3_X branch, as these changes have already been made there.
gROOT->GetClass(...) is obsolete. It just calls TClass::GetClass(...). Instead, calling TClass::GetClass() directly is recommended by the ROOT team, and it saves a function call.