Attempt to fix dictionary for edm::AssociationVector #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions The exception message which states that there is an incorrect put had the order of the C++ class type and the three strings used to identify a data product in a non-standard order.
Changed all the EDProducers to be stream types and added override declarations. Also VSimpleProducer and AVSimpleProducer to fill their containers with data which changes each event. This will be used in tests to guarantee that the content requested from an event is what was stored.
Added missing dictionaries needed for edm::AssociationVector Wrote an ioread rule for edm::AssociationVector but a bug in ROOT keeps it from being called.
Once the edm::AssociationVector dictionary problems were fixed, it was possible to use the class in the View test. Added a pyroot reading test for edm::AssociationVector. Unfortunately, a bug in ROOT prevents reading from working correctly. This unit test is commented out for now but will be activated once the ROOT bug is fixed.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X. Attempt to fix dictionary for edm::AssociationVector It involves the following packages: DataFormats/FWLite @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
nclopezo
added a commit
that referenced
this pull request
Oct 1, 2014
Attempt to fix dictionary for edm::AssociationVector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andrea Rizzi reported a problem reading edm::AssociationVectors from pyroot. The problem was a cache internal to edm::AssociationVector was not getting cleared on each event. An ioread rule was added for the class, however it appears there is a bug in ROOT which prevents this rule from being used.
This pull request sets up unit tests for edm::AssociationVector to prove it works properly in the full framework. There is also a commented out test for reading in pyroot which can be used to test any fixes in ROOT for the problem.