Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional suppressions for known calls to atomics #5644

Merged
merged 1 commit into from Oct 2, 2014
Merged

Added additional suppressions for known calls to atomics #5644

merged 1 commit into from Oct 2, 2014

Conversation

Dr15Jones
Copy link
Contributor

helgrind reports writes/reads of std::atomics as data races. Added
additional suppressions for known calls to std::atomics.

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 1, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X.

Added additional suppressions for known calls to atomics

It involves the following packages:

Utilities/ReleaseScripts

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

nclopezo commented Oct 2, 2014

@Dr15Jones
Hi Chris,
This pull request is not mergeable, could you please rebase it?

@Dr15Jones
Added additional suppressions for known calls to atomics
711d487 
helgrind reports writes/reads of std::atomics as data races. Added
additional suppressions for known calls to std::atomics.
@Dr15Jones Dr15Jones force-pushed the additionalSuppressionForAtomics branch from 8d10b1e to 711d487 Compare October 2, 2014 13:46
@Dr15Jones
Copy link
Contributor Author

@nclopezo Hopefully things will work better this time.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

Pull request #5644 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

+1
Tested at: 711d487
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5644/138/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5644/138/summary.html

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 2, 2014
@nclopezo
Merge pull request #5644 from Dr15Jones/additionalSuppressionForAtomics
5cb6e74 
Utilities/ReleaseScripts -- Added additional suppressions for known calls to atomics
@nclopezo nclopezo merged commit 5cb6e74 into cms-sw:CMSSW_7_3_X Oct 2, 2014
@Dr15Jones Dr15Jones deleted the additionalSuppressionForAtomics branch October 28, 2014 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @nclopezo