Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check of number of raw input files in DAQ input source #5649

Merged
merged 1 commit into from Oct 2, 2014

Conversation

smorovic
Copy link
Contributor

@smorovic smorovic commented Oct 2, 2014

*DAQ input source (EvFDaqDirector) will check the correct number of files in lumisection before moving on to the next one.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_1_X.

Check of number of raw input files in DAQ input source

It involves the following packages:

EventFilter/Utilities

@mommsen, @cmsbuild, @nclopezo, @emeschi can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mommsen
Copy link
Contributor

mommsen commented Oct 2, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

@@ -56,6 +56,7 @@ class DataPoint: public JsonSerializable {
virtual void deserialize(Json::Value& root);

std::vector<std::string>& getData() {return data_;}
std::string& getDefinition() {return definition_;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the next time around - perhaps its safer for this to return a const string&?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will change it fot the next time.
Thanks,
Srecko

davidlange6 added a commit that referenced this pull request Oct 2, 2014
Check of number of raw input files in DAQ input source
@davidlange6 davidlange6 merged commit 04d30e0 into cms-sw:CMSSW_7_1_X Oct 2, 2014
@smorovic smorovic deleted the bu-eols-parsing branch November 26, 2014 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants