repeating fix on 71x

[davidlange6]

Fix SimG4Core/Generators in 71x.

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_1_X.

repeating fix on 71x

It involves the following packages:

SimG4Core/Generators
Validation/EventGenerator

@vciulli, @civanch, @nclopezo, @mdhildreth, @cmsbuild, @thuer, @bendavid can you please review it and eventually sign? Thanks.
@makortel, @inugent this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

What's the status of this in 73X?
Is it still waiting for a forward port?

I see https://github.com/cms-sw/cmssw/blob/CMSSW_7_3_X/Validation/EventGenerator/src/HepMCValidationHelper.cc
(and the blame there suggests an interesting history of this assert coming in and going back and forth)

 assert(taudaughters.size()>0);
if ( taudaughters.size()==0 ) {
edm::LogError("HepMCValidationHelper") << "Tau with no daughters. This is a bug. Fix it";
continue;
}

My problem with this is a crash in a relval 1313 workflow (QCD)

[bendavid]

Slava, I guess you are running on some old GEN-SIM which had some of the problematic simulation interface code?

[slava77]

The job is reading /CMSSW_7_2_0_pre4/RelValQCD_Pt_3000_3500_13/GEN-SIM/POSTLS172_V3-v2

[bendavid]

Yup, pretty sure that is one of the releases with bugged GEN-SIM.

[slava77]

I'm running in the head of 73X (CMSSW_7_3_X_2014-10-07-0200)

do we have a set of samples with the GEN-SIM fixed?
(I should better move to HN though)

[bendavid]

Everything was fixed in 7_2_0_pre7 and GEN-SIM was redone for the relvals AFAIK.

[davidlange6]

720pre5 or pre7

On Oct 7, 2014, at 4:43 PM, Slava Krutelyov notifications@github.com
wrote:

In Validation/EventGenerator/src/HepMCValidationHelper.cc:

@@ -184,7 +184,10 @@ namespace HepMCValidationHelper {
for (unsigned int i = 0; i < taus.size(); ++i){
std::vector<const HepMC::GenParticle*> taudaughters;
findDescendents(taus[i], taudaughters);

•  assert(taudaughters.size()>0);
  

•  if ( taudaughters.size()<=0 ) {
  

• edm::LogError("HepMCValidationHelper") << "Tau with no daughters. This is a bug. Fix it";

I'm running in the head of 73X (CMSSW_7_3_X_2014-10-07-0200)

do we have a set of samples with the GEN-SIM fixed?
(I should better move to HN though)

—
Reply to this email directly or view it on GitHub.