Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithread-safe version which uses HistoJ for vectors #5655

Merged
merged 1 commit into from Oct 7, 2014

Conversation

avetisya
Copy link
Contributor

@avetisya avetisya commented Oct 2, 2014

This version of the JSON monitoring switches to edm::stream::EDAnalyzer and changes the structure written to JSON files to HistoJ per suggestions from the DAQ group. In addition to monitoring HLT accepts by path and processed events, it now also monitors L1 seed accepts, prescale accepts, rejects and errors by path as well as accepts by primary dataset.

Because the changes made by this module require corresponding changes in DAQ tools (hltd and Elastic Search), DAQ experts request that if possible, this change should go into a patch release on Monday or Tuesday rather than straight into the release used for MWGR8.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

A new Pull Request was created by @avetisya for CMSSW_7_1_X.

Multithread-safe version which uses HistoJ for vectors

It involves the following packages:

HLTrigger/JSONMonitoring

The following packages do not have a category, yet:

HLTrigger/JSONMonitoring

@cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2014

@Martin-Grunewald
Copy link
Contributor

@ktf
Please assign signature rights in github for HLTrigger/JSONMonitoring to HLT.
Thanks

@ktf
Copy link
Contributor

ktf commented Oct 6, 2014

@Martin-Grunewald done now.

@Martin-Grunewald
Copy link
Contributor

Thanks!

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @Degano can you please take care of it?

davidlange6 added a commit that referenced this pull request Oct 7, 2014
Multithread-safe version which uses HistoJ for vectors
@davidlange6 davidlange6 merged commit b2a78b7 into cms-sw:CMSSW_7_1_X Oct 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants