Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable parameters for nValidHits, nMissIn, nMissMid, maxRelTrkIsoDeltaRp3, relTrkIsoDeltaRSize #5665

Merged
merged 5 commits into from Oct 8, 2014

Conversation

jbrinson
Copy link
Contributor

@jbrinson jbrinson commented Oct 3, 2014

Added configurable parameters for nValidHits, nMissIn, nMissMid, and relTrkIsoDelaRp3

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2014

A new Pull Request was created by @jbrinson for CMSSW_7_3_X.

Mydev

It involves the following packages:

RecoTracker/DeDx

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2014

//calculate relative trk isolation only if parameter maxRelTrkIsoDeltaRp3 is different from default value of 99
if(maxRelTrkIsoDeltaRp3_ >= 0){
double ptCone = track->pt();
for(unsigned int j=0; j<trackCollection.size(); j++){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add here if(i==j) continue;
Then you don't need eta and phi comparisons below (except if there are special cases of two tracks same parameters)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

@slava77
Copy link
Contributor

slava77 commented Oct 8, 2014

+1

for #5665 3455dc5
based on jenkins
code is ok; nice to see the fillDescriptions implemented for everything

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 8, 2014
RecoTracker/DeDx -- Added configurable parameters for nValidHits, nMissIn, nMissMid, maxRelTrkIsoDeltaRp3, relTrkIsoDeltaRSize
@nclopezo nclopezo merged commit a4a5e7d into cms-sw:CMSSW_7_3_X Oct 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants