Forward port of remaining CMSSW_7_2_X bits into CMSSW_7_3_X. #5706
Conversation
Fix IB addOn tests
…MSSW_7_2_X_2014-09-29-0200 MiniAOD: set track_ as transient in PackedPFCandidate
…29-0200_metCodeFix add JECpayload protection in PhysicsTools/PatUtils/interface/ShiftedJetProducerT.h
A script that manages a FU/BU appliance is added.
…0_pre6 re-store for GEN relvals the EnableHarvesting in reqmgr
deriving ts5 correction from ts4
| @@ -185,10 +184,9 @@ namespace HepMCValidationHelper { | |||
| for (unsigned int i = 0; i < taus.size(); ++i){ | |||
| std::vector<const HepMC::GenParticle*> taudaughters; | |||
| findDescendents(taus[i], taudaughters); | |||
| assert(taudaughters.size()>0); | |||
| if ( taudaughters.size()==0 ) { | |||
| if ( taudaughters.size()<=0 ) { | |||
There was a problem hiding this comment.
taudaughters.size() is never < 0...
There was a problem hiding this comment.
yes, Alessandro changed this accordingly.
On Oct 6, 2014, at 7:08 PM, Giulio Eulisse notifications@github.com
wrote:
In Validation/EventGenerator/src/HepMCValidationHelper.cc:
@@ -185,10 +184,9 @@ namespace HepMCValidationHelper {
for (unsigned int i = 0; i < taus.size(); ++i){
std::vector<const HepMC::GenParticle*> taudaughters;
findDescendents(taus[i], taudaughters);
assert(taudaughters.size()>0);if ( taudaughters.size()==0 ) {if ( taudaughters.size()<=0 ) {taudaughters.size() is never < 0...
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
ah - never mind my comment.. yes - indeed - can be fixed when we re-enable the abort
There was a problem hiding this comment.
yeah... it should probably use std::vector::empty() as well..
|
+1 |
|
+1 |
Forward port of remaining CMSSW_7_2_X bits into CMSSW_7_3_X.
No description provided.