Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timeouts for the Xrootd client. #5714

Merged
merged 1 commit into from Oct 8, 2014

Conversation

bbockelm
Copy link
Contributor

@bbockelm bbockelm commented Oct 7, 2014

The default timeout is now set to 10 minutes; previously, it varied
between 3 minutes and 8 hours, depending on the operation. Further,
the timeout can now be set by the CMSSW pset and the site local
config service.

It appears that timeouts were never set for fallback files;
this issue is now fixed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_3_X.

Implement timeouts for the Xrootd client.

It involves the following packages:

IOPool/Input
Utilities/XrdAdaptor

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

Pull request #5714 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

-1
Tested at: 3f55e24
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log
----- Begin Fatal Exception 07-Oct-2014 12:17:45 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5714/187/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

@@ -8,6 +8,9 @@

class XrdStorageMaker : public StorageMaker
{
private:
static int timeout_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this static? It only seems accessible via member functions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't strictly have to be static - more that I've spent too much time in Java and I was worried about how to handle all the possible constructors properly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. In-class member initialization is in C++11 (which should prevent mistakes). I'll switch to that.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

Pull request #5714 was updated. @Dr15Jones, @ktf can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 8, 2014
Xrootd client -- Implement timeouts for the Xrootd client.
@nclopezo nclopezo merged commit a2d5ddf into cms-sw:CMSSW_7_3_X Oct 8, 2014
nclopezo added a commit that referenced this pull request Oct 24, 2014
Backport of #5714 to 72X: Implement timeouts for the Xrootd client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants