Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for online visualization #5721

Merged
merged 3 commits into from Oct 7, 2014

Conversation

cerminar
Copy link
Contributor

@cerminar cerminar commented Oct 7, 2014

This PR addresses the following issues:

  • GT for express is now used in he configuration adding the possibility to fetch it from Tier0das
  • remove lumiProducer from cosmics reco sequences

Ideally we could test this in the ongoing MWGRs

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

A new Pull Request was created by @cerminar for CMSSW_7_1_X.

Fixes for online visualization

It involves the following packages:

Configuration/DataProcessing
DQM/Integration

@nclopezo, @vlimant, @danduggan, @rovere, @cmsbuild, @franzoni, @deguio, @ojeda, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Oct 7, 2014

+1

@davidlange6
Copy link
Contributor

the lumi producer changes are ok if we never plan to run the cosmics sequence on collisions data (certainly not an issue for today)

davidlange6 added a commit that referenced this pull request Oct 7, 2014
@davidlange6 davidlange6 merged commit 29eea34 into cms-sw:CMSSW_7_1_X Oct 7, 2014
@danduggan
Copy link
Contributor

Even if we do run this on collisions, we should suppress lumi producer as this won't be needed for the purposes of this configuration - event display at p5. i imagine for collisions the lumi producer will/should also be suppressed.

@davidlange6
Copy link
Contributor

On Oct 8, 2014, at 9:42 AM, danduggan notifications@github.com
wrote:

Even if we do run this on collisions, we should suppress lumi producer as this won't be needed for the purposes of this configuration - event display at p5. i imagine for collisions the lumi producer will/should also be suppressed.

In the event display - sure - but this config (as implemented) is not just for the event display at p5.


Reply to this email directly or view it on GitHub.

@cerminar
Copy link
Contributor Author

cerminar commented Oct 8, 2014

Hi @davidlange6 ,
not sure what do you mean: this is just editing the configuration for visualization: the call to remove the lumi producer is only in that particular method...
Cheers,
G

@davidlange6
Copy link
Contributor

ah - I missed that…good. Thanks

On Oct 8, 2014, at 9:56 AM, cerminar notifications@github.com
wrote:

Hi @davidlange6 ,
not sure what do you mean: this is just editing the configuration for visualization: the call to remove the lumi producer is only in that particular method...
Cheers,
G


Reply to this email directly or view it on GitHub.

@cerminar
Copy link
Contributor Author

cerminar commented Oct 8, 2014

Hi @danduggan ,
if I understand correctly the lumiProducer is already out of the reco for pp (and added back with a dedciated customize for Tier0). This is why I have not modified the pp scenarios.
Cheers,
G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants