Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip-only triplet-based seeding steps #574

Merged
merged 1 commit into from Aug 21, 2013

Conversation

cerati
Copy link
Contributor

@cerati cerati commented Aug 20, 2013

Switched off by default for now (no difference is expected from this pull).
Results presented here: https://indico.cern.ch/getFile.py/access?contribId=4&resId=0&materialId=slides&confId=261789
Short summary of code changes below.

** RecoTracker/TkSeedGenerator **
Algorithm implemented in RecoTracker/TkSeedGenerator/plugins/MultiHitGeneratorFromChi2.
MultiHitGenerator classes are a generalization of corresponding HitTripletGenerator one; they create OrderedMultiHits, i.e. SeedingHitSets with undefined number of hits (thus allowing both triplets and pairs from the same generator).

** RecoTracker/TkSeedingLayers **
Adding RecoTracker/TkSeedingLayers/interface/OrderedMultiHits.h and adding zero size case to SeedingHitSets

** RecoTracker/IterativeTracking **
Adding python files for triplet-based iter5 and iter6 (both in default and PostLS1 versions):
RecoTracker/IterativeTracking/python/PixelLessTripletStep_cff.py
RecoTracker/IterativeTracking/python/TobTecHybridStep_cff.py
They are included but commented out in iterativeTk_cff.py

** RecoPixelVertexing/PixelTriplets **
moving files from plugins to interface,src so that the library with the needed symbols can be used in other packages (i.e. RecoTracker/TkSeedGenerator)

@thspeer
Copy link
Contributor

thspeer commented Aug 20, 2013

Working @thspeer

@thspeer
Copy link
Contributor

thspeer commented Aug 21, 2013

Tested e34fed6
No change in reco, as expected (CMSSW_7_0_X_2013-08-20-0200-574)

@cmsbuild
Copy link
Contributor

The following categories have been signed by speer (a.k.a. @thspeer on GitHub): Reconstruction

@cms-git-reconstruction

ktf added a commit that referenced this pull request Aug 21, 2013
strip-only triplet-based seeding steps
@ktf ktf merged commit 2764135 into cms-sw:CMSSW_7_0_X Aug 21, 2013
jbsauvan pushed a commit to jbsauvan/cmssw that referenced this pull request Jan 26, 2016
cmsbuild pushed a commit that referenced this pull request Nov 24, 2020
Remove duplicate GPU-related HCAL conditions records, and simplify the package dependencies moving the remaining ones to CondFormats/DataRecord.

Improve the handling of the GPU conditions payloads:
  - use cms::cuda::device::unique_ptr to automatically deallocate the memory;
  - use edm::propagate_const_array to ensure that the conditions data are not accidentally modified by client code;
  - use cms::cuda::copyAsync(...) to simplify the copy of the conditions to the device.
mariadalfonso pushed a commit to mariadalfonso/cmssw that referenced this pull request Nov 24, 2020
Remove duplicate GPU-related HCAL conditions records, and simplify the package dependencies moving the remaining ones to CondFormats/DataRecord.

Improve the handling of the GPU conditions payloads:
  - use cms::cuda::device::unique_ptr to automatically deallocate the memory;
  - use edm::propagate_const_array to ensure that the conditions data are not accidentally modified by client code;
  - use cms::cuda::copyAsync(...) to simplify the copy of the conditions to the device.
mariadalfonso pushed a commit to mariadalfonso/cmssw that referenced this pull request Nov 25, 2020
Remove duplicate GPU-related HCAL conditions records, and simplify the package dependencies moving the remaining ones to CondFormats/DataRecord.

Improve the handling of the GPU conditions payloads:
  - use cms::cuda::device::unique_ptr to automatically deallocate the memory;
  - use edm::propagate_const_array to ensure that the conditions data are not accidentally modified by client code;
  - use cms::cuda::copyAsync(...) to simplify the copy of the conditions to the device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants