Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport compilation fix #5749

Merged
merged 1 commit into from Oct 9, 2014
Merged

Conversation

davidlange6
Copy link
Contributor

signed unsigned comparison failing in gcc491.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2014

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_2_X.

backport compilation fix

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

davidlange6 added a commit that referenced this pull request Oct 9, 2014
@davidlange6 davidlange6 merged commit c1de147 into cms-sw:CMSSW_7_2_X Oct 9, 2014
@slava77
Copy link
Contributor

slava77 commented Oct 9, 2014

I guess the size_t version is just for 73X and later

@davidlange6
Copy link
Contributor Author

@slava77, I'm not sure I follow you?

On Oct 9, 2014, at 9:49 AM, Slava Krutelyov notifications@github.com
wrote:

I guess the size_t version is just for 73X and later


Reply to this email directly or view it on GitHub.

@davidlt
Copy link
Contributor

davidlt commented Oct 9, 2014

@davidlange6 unsigned was changed to size_t in CMSSW_7_3_X.

@davidlange6
Copy link
Contributor Author

ok, I missed that - I just followed this pr:

https://github.com/cms-sw/cmssw/pull/5676/files

interested people can do a more complete back port..

On Oct 9, 2014, at 9:54 AM, davidlt notifications@github.com
wrote:

@davidlange6 unsigned was changed to size_t in CMSSW_7_3_X.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants