Consumes jet met #575
Consumes jet met #575
Conversation
|
@perrotta @Martin-Grunewald can you please sign (still using the topic collector for the moment). @Martin-Grunewald can you confirm you receive this email? |
|
@nclopezo can you please run the automated tests? |
|
The following categories have been signed by gruenew (a.k.a. @Martin-Grunewald on GitHub): HLT @cms-git-hlt, @cms-git-fastsim |
|
Hi, I signed the request - (and received the e-mail - due to the explicit cc?). Best regards On Tue, 20 Aug 2013, Giulio Eulisse wrote:
Martin Martin W. Gruenewald e-mail: Martin.Grunewald@cern.ch |
ghost
assigned 
|
Hi, I took these changes on top of CMSSW_7_0_X_2013-08-21-0200, I ran the unit tests and RelVals, all tests passed. You can see the logs here: |
add Summer15_25nsV6 JEC
Remove SiPixelDigiHeterogeneousConverter as obsolete, should have been removed as part of cms-patatrack#100. Address review comments for SiPixelClustersCUDA: - remove commented out default constructor and private: from DeviceConstView; this is perhaps the best compromise between non-default constructors not being preferred for device allocations, and the use case in SiPixelRecHitSoAFromLegacy (for the expected life time of this class) - remove const getters with c_ prefix - improve constructor parameter name - use more initializer list - initialize nClusters_h Address review comments for SiPixelDigiErrorsCUDA: - use type alias - remove const getters with c_ prefix and other unnecessary methods - use more initializer list Address review comments for SiPixelDigisCUDA: - remove const getters with c_ prefix and other unnecessary methods - remove commented out default constructor and private: from DeviceConstView - add comments for remaining SiPixelDigisCUDA member arrays Move PixelErrorsCompact and SiPixelDigiErrorsSoa to DataFormats/SiPixelRawData, rename classes Address review comments for SiPixelErrorsSoA - remove redundant assert - move constructor inline Address review comments for SiPixelDigisSoA - remove redundant assert - add comments Enable if constexpr also for CUDA in TrackingRecHit2DHeterogeneous Move dictionary of HostProduct<unsigned int[]> to CUDADataFormats/Common
Migrate to consumes/getByToken in all modules
Add also fillDescriptions() when missing