Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updat of some HLT filters for Egamma paths entering in 73X #5772

Merged
merged 11 commits into from Nov 13, 2014

Conversation

matteosan1
Copy link
Contributor

  • dZ filter adapted to work with RecoEcalCandidates (HLTrigger/filters)
  • Added a templated and more general version of PFMT filter (HLTrigger/Egamma)
  • Added FED producer for Single Electron path to be used in the ECAL calibration stream (Calibration/EcalAlCaRecoProducers)
  • Updated Filter to to perform the selection in regions of pseudo rapidity for the barrel and endcap in pi0/eta calibration paths (HLTrigger/special)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_3_X.

Updat of some HLT filters for Egamma paths entering in 73X

It involves the following packages:

Calibration/EcalAlCaRecoProducers
HLTrigger/Egamma
HLTrigger/HLTfilters
HLTrigger/special

@perrotta, @cmsbuild, @diguida, @cerminar, @Martin-Grunewald, @nclopezo, @rcastello, @fwyzard can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.


void HLTElectronPFMTFilter::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For templated classes, the fillDescriptions call to
descriptions.add("hltElectronPFMTFilter",desc);
has to be changed, see other templated filters as example.

@Martin-Grunewald
Copy link
Contributor

In HLTrigger/special/src/HLTEcalResonanceFilter.cc
you are adding/removing A LOT of parameters which will make this
not-backward compatible even with a fillDescriptions method.
(Old parameters in old configs will not be recognised and flagged as
error when running the new code).

This would probably mean a migration and a backport to 72X as well, as people need to be able
to run the (updated development) menus also in 72X

// only in debugging mode
if(debug_){

std::cout<<"############################################################## "<<std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No cout!

@Martin-Grunewald
Copy link
Contributor

Maybe just rename it to HLTRegionalEcalResonanceFilter.cc

@matteosan1
Copy link
Contributor Author

Yes it is probably easier.
Anyway I will ask the authors since I am just collecting mot of these
changes.

On 10/10/14 14:53, Martin Grunewald wrote:

Maybe just rename it to HLTRegionalEcalResonanceFilter.cc


Reply to this email directly or view it on GitHub:
#5772 (comment)

Matteo Sani
University of California, San Diego
+41227671577

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Nov 13, 2014

+1
Conditional approval: as discussed in person with @matteosan1 there are still some optimisations to be done on the AlCa side, so some timing studies are needed.
We will follow up on this, and come to a new PR soon.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 13, 2014
Updat of some HLT filters for Egamma paths entering in 73X
@cmsbuild cmsbuild merged commit b9c374b into cms-sw:CMSSW_7_3_X Nov 13, 2014
shervin86 pushed a commit to shervin86/cmssw that referenced this pull request May 11, 2015
Updat of some HLT filters for Egamma paths entering in 73X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet