New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updat of some HLT filters for Egamma paths entering in 73X #5772
Updat of some HLT filters for Egamma paths entering in 73X #5772
Conversation
matteosan1
commented
Oct 10, 2014
- dZ filter adapted to work with RecoEcalCandidates (HLTrigger/filters)
- Added a templated and more general version of PFMT filter (HLTrigger/Egamma)
- Added FED producer for Single Electron path to be used in the ECAL calibration stream (Calibration/EcalAlCaRecoProducers)
- Updated Filter to to perform the selection in regions of pseudo rapidity for the barrel and endcap in pi0/eta calibration paths (HLTrigger/special)
A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_3_X. Updat of some HLT filters for Egamma paths entering in 73X It involves the following packages: Calibration/EcalAlCaRecoProducers @perrotta, @cmsbuild, @diguida, @cerminar, @Martin-Grunewald, @nclopezo, @rcastello, @fwyzard can you please review it and eventually sign? Thanks. |
|
||
void HLTElectronPFMTFilter::fillDescriptions(edm::ConfigurationDescriptions& descriptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For templated classes, the fillDescriptions call to
descriptions.add("hltElectronPFMTFilter",desc);
has to be changed, see other templated filters as example.
In HLTrigger/special/src/HLTEcalResonanceFilter.cc This would probably mean a migration and a backport to 72X as well, as people need to be able |
// only in debugging mode | ||
if(debug_){ | ||
|
||
std::cout<<"############################################################## "<<std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No cout!
Maybe just rename it to HLTRegionalEcalResonanceFilter.cc |
Yes it is probably easier. On 10/10/14 14:53, Martin Grunewald wrote:
Matteo Sani |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Updat of some HLT filters for Egamma paths entering in 73X
Updat of some HLT filters for Egamma paths entering in 73X