Optimisation a la Chris of HLTrigger/btau/src/L3MumuTrackingRegion. #586
Conversation
|
The following categories have been signed by gruenew (a.k.a. @Martin-Grunewald on GitHub): HLT @cms-git-hlt, @cms-git-fastsim |
ghost
assigned 
| @@ -27,6 +27,7 @@ class L3MumuTrackingRegion : public TrackingRegionProducer { | |||
| edm::ParameterSet regionPSet = cfg.getParameter<edm::ParameterSet>("RegionPSet"); | |||
|
|
|||
| theVertexTag = regionPSet.getParameter<edm::InputTag>("vertexSrc"); | |||
| theVertex = (theVertexTag.label().length()>1); | |||
There was a problem hiding this comment.
I know >1 was in the original code but shouldn't this be >0 so one could test with modules who only have a single letter as their module label?
|
@Martin-Grunewald do you plan to fix this as suggested by chris in the very short term? |
|
Sorry, no, not in the very short term. |
|
Ok. Unless Chris objects I'll merge this as soon as I get the results of the tests from @nclopezo |
|
I have no objections. Chris Sent from my iPhone On Aug 22, 2013, at 11:56 AM, Giulio Eulisse notifications@github.com wrote:
|
Optimisation a la Chris of HLTrigger/btau/src/L3MumuTrackingRegion.
Soft activity for EWK analysis
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
Optimisation a la Chris of HLTrigger/btau/src/L3MumuTrackingRegion.