Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop genParticles process name to fix empty histograms in FastSim. #5868

Merged
merged 1 commit into from Oct 17, 2014
Merged

Drop genParticles process name to fix empty histograms in FastSim. #5868

merged 1 commit into from Oct 17, 2014

Conversation

thomreis
Copy link
Contributor

Hard coded genParticles process name resulted in empty histograms in FastSim after the consumes migration in 7_0_0_pre10.

This affects all Egamma HLT FastSim Relval starting from 7_0_0_pre10.

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 17, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_7_3_X.

Drop genParticles process name to fix empty histograms in FastSim.

It involves the following packages:

HLTriggerOffline/Egamma

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@thomreis thomreis mentioned this pull request Oct 17, 2014
Merged
@deguio
Copy link
Contributor

deguio commented Oct 17, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
Tested at: 2c6b64c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5868/114/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 17, 2014
@nclopezo
Merge pull request #5868 from thomreis/EmDQM_FastSim_bugfix
56f8290 
HLTriggerOffline/Egamma -- Drop genParticles process name to fix empty histograms in FastSim.
@nclopezo nclopezo merged commit 56f8290 into cms-sw:CMSSW_7_3_X Oct 17, 2014
@thomreis thomreis deleted the EmDQM_FastSim_bugfix branch October 17, 2014 12:52
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5868/114/summary.html

nclopezo added a commit to nclopezo/cmssw that referenced this pull request Oct 21, 2014
@nclopezo
Revert "Merge pull request cms-sw#5868 from thomreis/EmDQM_FastSim_bu…
642fc2d 
…gfix"

This reverts commit 56f8290, reversing
changes made to a489262.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thomreis @cmsbuild @deguio @nclopezo