Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgcal Thermal Screen #5905

Merged
merged 13 commits into from
Oct 22, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Oct 21, 2014

  • Add pilot beampipe scenario with AlBe composition
  • Add HGCal thermal screen at the bottom

@ianna
Copy link
Contributor Author

ianna commented Oct 21, 2014

@lgray and @fratnikov - as discussed with Karl and Austin, this is a pilot AlBe beampipe. Also a thermal screen is added at 3 eta. As Karl requested, I'll add HGCal support at 3 eta as well - just need to know its thickness and composition.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_6_2_X_SLHC.

Hgcal Thermal Screen

It involves the following packages:

Geometry/CMSCommonData
Geometry/EcalCommonData
Geometry/ForwardCommonData
Geometry/HGCalCommonData
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @argiro, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Oct 21, 2014

Thanks!

@ianna dimensions and composition of HGCal thermal screen? Is this just an extension to cover eta3?
@fratnikov please check this out as soon as you are done studying the aluminum beampipe.

@bachtis

@ianna
Copy link
Contributor Author

ianna commented Oct 21, 2014

@lgray - The assumption for thermal screen are: 21 mm thick in R - 0.1 Al + 1.9 Foam + 0.1 Al
Stainless steel support is 6 mm thickness in R and covers Z from 299 cm to 417.5 cm

@cmsbuild
Copy link
Contributor

Pull request #5905 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@vandreev11
Copy link
Contributor

@gray @fratnikov @bachtis @pfs
@ianna Dear Ianna, than you for taking care of it for HGCAL inner thermal screen and support. I knew about your PR by chance. I submitted V5 geometry modifications with PR5838. I propose to disconnect
your beam pipe modifications from HGCAL related modifications. To put all HGCAL stuff into v5 directory.
If you do not like it, then I see some corrections needed in your HGCAL related stuff. Namely, support material is Aluminium. The inner thermal screen has gap 8 mm air, then 2mm Aluminium, 16 mm foam and again 2mm Aluminium. RminHGCal44=4109.85mm; slope2=19.3deg, RmaxHGCal1=1534.5mm,RmaxHGCal4=2458.0mm. Cheers, Valeri

@ianna
Copy link
Contributor Author

ianna commented Oct 21, 2014

@vandreev11 - This PR creates a new Pilot scenario as requested by TP and can be easily removed/modified to use HGCal v5 when your PR#5838 is integrated into an IB or release. I do not think, they conflict. My intention was to send you an e-mail next.

screen shot 2014-10-21 at 15 56 16
screen shot 2014-10-21 at 15 59 38

@ianna
Copy link
Contributor Author

ianna commented Oct 21, 2014

@vandreev11 - I do not see bottom thermal screen nor support in vandreev11:hgc-v5-geometry-modifications2

screen shot 2014-10-21 at 16 25 02

@vandreev11
Copy link
Contributor

@ianna - inner thermal screen and support are entered through hgcal.xml global frame. PR5838 has modifications which are not compatible with this PR5905. I believe it is better to synchronize hgcal.xml.
The best way is to add your inner thermal screen and support structure implementation to v5. Then Pilot scenario means modifications of beam pipe, etc. - no HGCAL changes, while having HGCAL as default (V5 geometry) in such scenario. Means no V5/Pilot HGCAL directory. I hope you would agree with this proposal.

@cmsbuild
Copy link
Contributor

Pull request #5905 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Oct 22, 2014

@vandreev11 - I've corrected the thickness according to Sasha's drawing, but the ~3 mm Carbon layer is not there yet. I'll leave it with you if and when you'd want to integrate it into a mainstream scenario.

@lgray and @fratnikov - I think, this is final. I'd encourage Pixel guys to look into their cable material description in the hot region. It seems, the cables are densely packed - the material they've described is nearly 50% Cu in a cylinder of 1 cm thick.

screen shot 2014-10-22 at 10 37 30

@ianna
Copy link
Contributor Author

ianna commented Oct 22, 2014

Just for the record - we've discussed it with @vandreev11 and agreed that he will take care of putting the HGCal screen and support in v5.

@mark-grimes - it would probably be faster and easier if this PR is merged to an IB. Please, let me know if it's not the case, I'd need to extract an AlBe beampipe in a separate PR otherwise. Thanks.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes (tests are also fine). @fratnikov, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

@mark-grimes
Copy link

merge

Erm... try again. If this doesn't work I'll ask the software support team to merge it in the morning.

@mark-grimes
Copy link

Just seen github thinks there are merge conflicts. I had no problems when I merged it, I'll have a proper look in the morning.

cmsbuild added a commit that referenced this pull request Oct 22, 2014
@cmsbuild cmsbuild merged commit 9dc0a0a into cms-sw:CMSSW_6_2_X_SLHC Oct 22, 2014
@ianna ianna deleted the hgcal-thermal-screen branch October 26, 2015 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants