-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hgcal Thermal Screen #5905
Hgcal Thermal Screen #5905
Conversation
ianna
commented
Oct 21, 2014
- Add pilot beampipe scenario with AlBe composition
- Add HGCal thermal screen at the bottom
@lgray and @fratnikov - as discussed with Karl and Austin, this is a pilot AlBe beampipe. Also a thermal screen is added at 3 eta. As Karl requested, I'll add HGCal support at 3 eta as well - just need to know its thickness and composition. |
A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_6_2_X_SLHC. Hgcal Thermal Screen It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks. |
Thanks! @ianna dimensions and composition of HGCal thermal screen? Is this just an extension to cover eta3? |
@lgray - The assumption for thermal screen are: 21 mm thick in R - 0.1 Al + 1.9 Foam + 0.1 Al |
Pull request #5905 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
@gray @fratnikov @bachtis @pfs |
@vandreev11 - This PR creates a new Pilot scenario as requested by TP and can be easily removed/modified to use HGCal v5 when your PR#5838 is integrated into an IB or release. I do not think, they conflict. My intention was to send you an e-mail next. |
@vandreev11 - I do not see bottom thermal screen nor support in vandreev11:hgc-v5-geometry-modifications2 |
@ianna - inner thermal screen and support are entered through hgcal.xml global frame. PR5838 has modifications which are not compatible with this PR5905. I believe it is better to synchronize hgcal.xml. |
Pull request #5905 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
@vandreev11 - I've corrected the thickness according to Sasha's drawing, but the ~3 mm Carbon layer is not there yet. I'll leave it with you if and when you'd want to integrate it into a mainstream scenario. @lgray and @fratnikov - I think, this is final. I'd encourage Pixel guys to look into their cable material description in the hot region. It seems, the cables are densely packed - the material they've described is nearly 50% Cu in a cylinder of 1 cm thick. |
Just for the record - we've discussed it with @vandreev11 and agreed that he will take care of putting the HGCal screen and support in v5. @mark-grimes - it would probably be faster and easier if this PR is merged to an IB. Please, let me know if it's not the case, I'd need to extract an AlBe beampipe in a separate PR otherwise. Thanks. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes (tests are also fine). @fratnikov, @mark-grimes can you please take care of it? |
merge |
merge Erm... try again. If this doesn't work I'll ask the software support team to merge it in the morning. |
Just seen github thinks there are merge conflicts. I had no problems when I merged it, I'll have a proper look in the morning. |