include pilot blade stuff to pixel rawdigi, 2nd attempt #5961
Conversation
|
A new Pull Request was created by @dkotlins for CMSSW_7_3_X. include pilot blade stuff to pixel rawdigi, 2nd attempt It involves the following packages: EventFilter/SiPixelRawToDigi @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
| @@ -97,6 +98,11 @@ class PixelDataFormatter { | |||
| int hasDetDigis; | |||
| ErrorChecker errorcheck; | |||
|
|
|||
| // For the 32bit data format (moved from ccnamespace) | |||
| int ADC_shift, PXID_shift, DCOL_shift, ROC_shift, LINK_shift; | |||
There was a problem hiding this comment.
CMS style is to have all class members to start from a lower case;
upper case is reserved for type names
There was a problem hiding this comment.
ALL Tracker code in EventFilter use this type of notation. It is historical. Make no sense to change it 20 year after.
There was a problem hiding this comment.
it's OK for constants (and they were for 20 years and we are changing them)
They are not constants anymore here.
I would not insist though.
|
Since this appears to be just a temporary solution, Danek, please update the description of the pull request to clarify this. |
|
Based on our reco tests this PR is fine. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. |
cmsbuild
added
comparison-pending
fully-signed
and removed
comparison-pending
fully-signed
reconstruction-approved
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
include pilot blade stuff to pixel rawdigi, 2nd attempt
Include pilot-blade in raw2digi.
Add the new data format for phase1 pixels.