Remove unneeded function #5969
Merged
Remove unneeded function #5969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_3_ROOT6_X. Remove unneeded function It involves the following packages: DataFormats/PatCandidates @Dr15Jones, @monttj, @cmsbuild, @nclopezo, @vadler, @ktf can you please review it and eventually sign? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function TypeWithDict::hasDictionary() can be removed. In ROOT6, it will not work correctly for enums, pointers, or C style arrays, because TypeWithDict does not necessarily have a correct type_info for these types. The use of this function is replaced by use of the existing hasDictionary() free function, which takes the type_info as its input argument.
Please merge this as soon as convenient.