Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary introspection for MVAComputer #5975

Merged
merged 1 commit into from Oct 24, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 23, 2014

NOTE: Do not merge this pull request into CMSSW_7_3_ROOT6_X, as there will be merge conflicts.
This pull request is for code commonality between CMSSW for ROOT 5 and ROOT 6.
In the ROOT6 IB, unnecessary introspection has been removed from MVAComputer, to save memory and increase performance, as this particular use of introspection causes run-time header parsing.
This pull request makes the equivalent change in the CMSSW ROOT 5 IB, for code commonality.
The introspection was used to invoke the copy constructor of classes derived from VarProcessor.
In less than an hour, I was able to replace this ugly introspection with a virtual clone() function, which can be called directly.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_3_X.

Avoid unnecessary introspection for MVAComputer

It involves the following packages:

CondFormats/PhysicsToolsObjects

@apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor

+1
thanks Bill !

On Fri, Oct 24, 2014 at 1:52 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @wmtan https://github.com/wmtan for
CMSSW_7_3_X.

Avoid unnecessary introspection for MVAComputer

It involves the following packages:

CondFormats/PhysicsToolsObjects

@apfeiffer1 https://github.com/apfeiffer1, @nclopezo
https://github.com/nclopezo, @cerminar https://github.com/cerminar,
@cmsbuild https://github.com/cmsbuild, @diguida
https://github.com/diguida, @rcastello https://github.com/rcastello,
@ggovi https://github.com/ggovi, @mmusich https://github.com/mmusich
can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@nclopezo https://github.com/nclopezo, @ktf https://github.com/ktf
you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#5975 (comment).

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Oct 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 24, 2014
CondFormats/PhysicsToolsObjects -- Avoid unnecessary introspection for MVAComputer
@nclopezo nclopezo merged commit 4ee8e37 into cms-sw:CMSSW_7_3_X Oct 24, 2014
@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented Oct 24, 2014

Did you make sure this will not be merged in ROOT6 as Bill asked?

nclopezo added a commit to nclopezo/cmssw that referenced this pull request Oct 24, 2014
@wmtan wmtan deleted the AvoidUnneededIntrospection branch November 4, 2014 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants