unused duplicate plugin removed

[yetkinyilmaz]

Unused CentralityPopConProducer is removed.
It was causing duplicate plugin problem, because HiCentralityAlgos is exported in other places.

[cmsbuild]

A new Pull Request was created by @yetkinyilmaz for CMSSW_7_3_X.

unused duplicate plugin removed

It involves the following packages:

RecoHI/HiCentralityAlgos

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@azsigmon, @jazzitup, @richard-cms, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[StoyanStoynev]

@cmsbuild please test

[cmsbuild]

+1
Tested at: 86848e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5990/374/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5990/374/summary.html

[StoyanStoynev]

When I run the duplicate library search with this PR I still get the warning about CentralityPopConProducer:

duplicateReflexLibrarySearch.py --edmFile $CMSSW_BASE/lib/$SCRAM_ARCH/.edmplugincache --edmPD
CentralityPopConProducer
pluginHiCentralityPlugins.so
pluginRecoHIHiEvtPlaneAlgos.so

Chi2ChargeMeasurementEstimatorESProducer
pluginRecoTrackerMeasurementDetPlugins.so
pluginTrackingToolsKalmanUpdatorsPlugins.so

As I understand the first one is supposed not to appear above. How do I test the PR does what it intends to do (I tried cleaning with scramv1 b distclean)?
My tests are with this PR on top of CMSSW_7_3_X_2014-10-25-0200 (gss491). I don't see other issues (HI RECO runs fine, no diffs in outputs).

[StoyanStoynev]

And for the record - also tried scramv1 b -r .

[slava77]

no, the first one will appear because the search is done over all the release plugins

the second one will disappear after IB is rebuilt from scratch.
We discussed it in #5853 (comment)

[StoyanStoynev]

+1
OK for 86848e9 . No diffs in short matrix tests (including 140.51 whic is HI RECO). Tests made with CMSSW_7_3_X_2014-10-25-0200 (gss491).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.