Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed confusing use of unscheduled term in global exception message #6027

Merged
merged 1 commit into from Oct 27, 2014
Merged

Removed confusing use of unscheduled term in global exception message #6027

merged 1 commit into from Oct 27, 2014

Conversation

Dr15Jones
Copy link
Contributor

The use of the term 'unscheduled' when an exception occurred during a 'global' transition was causing confusion. The term has now been dropped and the message now explicitly says it is a global transition.

@Dr15Jones
Removed confusing use of unscheduled term in global exception message
6b5acdf 
The use of the term 'unscheduled' when an exception occurred during a 'global' transition was causing confusion. The term has now been dropped and the message now explicitly says it is a global transition.
@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 27, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X.

Removed confusing use of unscheduled term in global exception message

It involves the following packages:

FWCore/Framework

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

+1
Tested at: 6b5acdf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6027/402/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Oct 27, 2014
@cmsbuild
Merge pull request #6027 from Dr15Jones/removeUnscheduledTermFromGlob…
63b0bd3 
…alExceptions

Removed confusing use of unscheduled term in global exception message
@cmsbuild cmsbuild merged commit 63b0bd3 into cms-sw:CMSSW_7_3_X Oct 27, 2014
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6027/402/summary.html

@Dr15Jones Dr15Jones deleted the removeUnscheduledTermFromGlobalExceptions branch October 28, 2014 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending core-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dr15Jones @cmsbuild