New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeSlew modelling update #6103
Conversation
A new Pull Request was created by @abdoulline for CMSSW_7_3_X. TimeSlew modelling update It involves the following packages: SimCalorimetry/HcalSimAlgos @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
Hi Salavat, in line 52 the vector is not fully initialized. Why not replace lines 51-52 by Also it seems that in the line 78 vector is filled out of the vector boundary. In line 80 it is possible to have |
moning implementation" then left "abandoned"...). On Thu, 30 Oct 2014, Vladimir Ivantchenko wrote:
|
Pull request #6103 was updated. @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please check and sign again. |
Hi Salavat, Thanks |
(privately) evaluated now. On Thu, 30 Oct 2014, Slava Krutelyov wrote:
|
For e=50 GeV pions ECAL+HCAL scan there is 5-6% scale reduction "out of the box" (~10% in HCAL) with Method 1 (current default). To correct for it, better to have this Digitization update coupled with Method 2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
NB: to have it more adequate to 25ns high-PU simulation. Needs to be included in 73X in sync with "Method 2"
#5954
(1)
Current TimeSlew modelling has been developed/implemented quite some time ago and it relies on the "standalone" signal properties, evaluating the time delay of the signal based on the total charge collected in 4TS. It was OK for low-PU sparse BX simulation , but becomes less adequate for high-PU 25ns regime.
(2)
This update still uses existing "TimeSlew vs full-signal" parametrization, but it makes estimates for "full signal" for each 1TS and delays each TS accordingly, which corresponds better to the hardware operation mode.
Still keeps previous TimeSlew smearing evaluated in 2010 (to mimic real data timing variation).
(3)
More advanced and detailed simulation of the HCAL FE electronics properties is being developed, but out of scope of 730.