Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Fireworks changes from 72x to 73x #6124

Merged
merged 2 commits into from Oct 31, 2014
Merged

Conversation

alja
Copy link
Contributor

@alja alja commented Oct 30, 2014

Synchronize Fireworks/Core directories.
Next time do this with cherry-pick.

@alja
Copy link
Contributor Author

alja commented Oct 30, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

Don't create a default GL viewer.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_3_X.

Port Fireworks changes from 72x to 73x

It involves the following packages:

Fireworks/Core
Fireworks/FWInterface

@cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #6124 was updated. @cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@alja
Copy link
Contributor Author

alja commented Oct 31, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Oct 31, 2014
Port Fireworks changes from 72x to 73x
@cmsbuild cmsbuild merged commit 104baa3 into cms-sw:CMSSW_7_3_X Oct 31, 2014
@cmsbuild
Copy link
Contributor

@alja alja deleted the 73_port_core branch May 11, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants