Fixed bug where we could return a const & to a temporary from ParameterSet::getUntrackedParameterSet* #615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to getUntrackedParameterSet* to no longer register the default value
to the Registry lead to the bug where if the user passed in a temporary as the default then
that temporary could be returned by const&. If the user's receiving variable is also a const&
then one has an address to a temporary which the compiler can delete after that C++ line ends.