Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where we could return a const & to a temporary from ParameterSet::getUntrackedParameterSet* #615

Merged

Conversation

Dr15Jones
Copy link
Contributor

The recent change to getUntrackedParameterSet* to no longer register the default value
to the Registry lead to the bug where if the user passed in a temporary as the default then
that temporary could be returned by const&. If the user's receiving variable is also a const&
then one has an address to a temporary which the compiler can delete after that C++ line ends.

The recent change to getUntrackedParameterSet* to no longer register the default value
to the Registry lead to the bug where if the user passed in a temporary as the default then
that temporary could be returned by const&. If the user's receiving variable is also a const&
then one has an address to a temporary which the compiler can delete after that C++ line ends.
@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Aug 26, 2013
…meterSet

Fixed bug where we could return a const & to a temporary from ParameterSet::getUntrackedParameterSet*
@ktf ktf merged commit 30880ab into cms-sw:CMSSW_7_0_X Aug 26, 2013
mmarionncern pushed a commit to mmarionncern/cmssw that referenced this pull request May 23, 2016
mmarionncern pushed a commit to mmarionncern/cmssw that referenced this pull request May 23, 2016
Import basic CMGTools as up to PR cms-sw#615 (midnight 22 Jan 2016)
arizzi added a commit to arizzi/cmssw that referenced this pull request Jan 13, 2017
HEPPY: QGL training updated in two commits (central heppy and heppy)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants