Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DTObjects thread safe #6154

Merged
merged 1 commit into from Nov 4, 2014

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer found that the objects were calling the non-const
version of 'find' for a pointer member variable. By assigning the same
address to a pointer to const we now make sure the const 'find' is called.

The static analyzer found that the objects were calling the non-const
version of 'find' for a pointer member variable. By assigning the same
address to a pointer to const we now make sure the const 'find' is called.
@Dr15Jones
Copy link
Contributor Author

These are the second to last EventSetup objects which are not yet thread safe.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X.

Make DTObjects thread safe

It involves the following packages:

CondFormats/DTObjects

@apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2014

@diguida
Copy link
Contributor

diguida commented Nov 4, 2014

+1

@apfeiffer1
Copy link
Contributor

+1

On Tue, Nov 4, 2014 at 9:10 AM, Salvatore Di Guida <notifications@github.com

wrote:

+1


Reply to this email directly or view it on GitHub
#6154 (comment).

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 4, 2014
@cmsbuild cmsbuild merged commit 748606b into cms-sw:CMSSW_7_3_X Nov 4, 2014
@Dr15Jones Dr15Jones deleted the threadSafeDTObjects branch November 4, 2014 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants