Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove include of unused deprecated header #6210

Merged
merged 1 commit into from Nov 5, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 4, 2014

Remove the include of an unused deprecated header. This header does not exist at all in ROOT6, and this include breaks the build.
This request is utterly trivial.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2014

A new Pull Request was created by @wmtan for CMSSW_7_3_X.

Remove include of unused deprecated header

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Nov 5, 2014

I'll +1 once jenkins compiles it

@ktf
Copy link
Contributor

ktf commented Nov 5, 2014

If it does not compile jenkins will refuse to merge it, so you can just +1 it and forget about it, i guess...

Sent from my iPhone

On 05/nov/2014, at 02:05, Slava Krutelyov notifications@github.com wrote:

I'll +1 once jenkins compiles it


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2014

@slava77
Copy link
Contributor

slava77 commented Nov 5, 2014

+1

for #6210 707dcc7
jenkins OK

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 5, 2014
Remove include of unused deprecated header
@cmsbuild cmsbuild merged commit 2bee3fe into cms-sw:CMSSW_7_3_X Nov 5, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2014

@wmtan wmtan deleted the RemoveObsoleteInclude branch November 10, 2014 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants