GeneratorInterface/Core: drop VLA of non-POD type #6292
Conversation
The patch resolves Clang compile errors regarding usage of VLA with non-POD types. VLA are not part of C++ standard. It's GNU extension originating from GCC. Use a standard array on the heap instead as performance is not a priority in endJob(). Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_3_X. GeneratorInterface/Core: drop VLA of non-POD type It involves the following packages: GeneratorInterface/Core @vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks. |
|
@bendavid fine to wait, but for reference they do not conflict (just tested by merging both). |
|
ping^1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
…e-Core GeneratorInterface/Core: drop VLA of non-POD type
…terface-Core GeneratorInterface/Core: drop VLA of non-POD type
…terface-Core GeneratorInterface/Core: drop VLA of non-POD type
The patch resolves Clang compile errors regarding usage of VLA with
non-POD types. VLA are not part of C++ standard. It's GNU extension
originating from GCC. Use a standard array on the heap instead as
performance is not a priority in
endJob().Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch