Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #6012 from cms-analysis-tools/CMSSW_7_3_X_AT_genHFHad... #6297

Merged

Conversation

bartosik-hep
Copy link
Contributor

Backport of the GenHFHadronMatcher from the CMSSW_7_3_X.
GenHFHadronMatcher using the official JetFlavour tool for hadron-jet association.

…_genHFHadronOrigin

GenHFHadronMatcher using the official JetFlavour tool for hadron-jet association
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2014

A new Pull Request was created by @bartosik-desy (Nazar Bartosik) for CMSSW_7_2_X.

Merge pull request #6012 from cms-analysis-tools/CMSSW_7_3_X_AT_genHFHad...

It involves the following packages:

PhysicsTools/JetMCAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link

vadler commented Nov 10, 2014

@bartosik-desy : Could you please comment, why we need this to be back-ported?
( @davidlange6 would ask anyway ;-) )

@vadler
Copy link

vadler commented Nov 10, 2014

+1
Tested with CMSSW_7_2_X_2014-11-09-0200.
Changes (incl. the expected slight changes in the output) are identical to those in #6012 .

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @davidlange6, @smuzaffar

@bartosik-hep
Copy link
Contributor Author

@vadler This needs to be backported in order to have the signal definitions based on this tool available in the current CMSSW_7_X release. This would also simplify installation instructions for the TWiki that is being prepared for the tool.

@vadler
Copy link

vadler commented Nov 10, 2014

@bartosik-desy : I guess, what you mean is, that this uses a feature correctly now, which is standard in the 7XY series anyway, right?

@bartosik-hep
Copy link
Contributor Author

@vadler Yes, of course. It is using the official JetFlavour tool for matching hadrons to jets instead of custom implementation that is present in the current 7_2_X release.

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants