Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If test fails, return a non-zero exit code #6318

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 10, 2014

This pull request affects unit tests only.
Many unit tests in CondCore/* packages return a zero return value even if the test fails. This causes failures to not be reported as failures in the IB.
In the ROOT 6 IB, there were approximately 15 test failures that were not noticed until now because of this.
NOTE: Since these code changes are not ROOT 6 specific, they are also being pull requested in the main 7_3_X branch for code commonality.
Please merge this request in the ROOT6 branch as soon as convenient.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_3_ROOT6_X.

If test fails, return a non-zero exit code

It involves the following packages:

CondCore/DBCommon
CondCore/IOVService
CondCore/ORA

@apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Nov 10, 2014
If test fails, return a non-zero exit code
@davidlt davidlt merged commit a551a47 into cms-sw:CMSSW_7_3_ROOT6_X Nov 10, 2014
@wmtan wmtan deleted the ReturnNonZeroIfUnitTestFails branch November 11, 2014 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants