Hcal DQM Migration - II.2

[cowden]

This should complete the HCAL DQM migration to MT framework. This affects DQM/HcalMonitorClient and DQM/HcalMonitorTasks. The use of helper classes inheriting from a common base class made it dificult to trace for every case the functional flow of the monitors and clients. However, with the exception of the removal of endRun(void) methods in HcalBaseDQClient and its derivatives, the functionality is intended to be the same in both frameworks.

[cmsbuild]

A new Pull Request was created by @cowden (Christopher Cowden) for CMSSW_7_3_X.

Hcal DQM Migration - II.2

It involves the following packages:

DQM/HcalMonitorClient
DQM/HcalMonitorTasks

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: 213ae86
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6337/818/summary.html

[deguio]

hello @cowden
thanks. I see that not all my comments have been addressed:

• please remove HcalBaseDQMonitor::endJob. it won’t be triggered anyway.
• please move what you do in HcalBaseDQMonitor::beginJob in the actor.
• in many cases (~all the helper classes) I see that not all the pointers allocated with new are deleted in the destructor. please make sure that the code doesn't leak by adding the delete or by using smart pointers
• please adjust the indentation: sometimes the code is not easily readable. see for example: HcalSummaryClient
  cheers,
  F.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6337/818/summary.html

[cmsbuild]

+1
Tested at: 2bdfa34
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6337/925/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6337/925/summary.html

[deguio]

+1
it seems to me that all my comments have been implemented.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.