Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up DQM/HLTEvF based on Clang warnings/errors #6359

Merged
merged 3 commits into from Nov 13, 2014
Merged

Clean up DQM/HLTEvF based on Clang warnings/errors #6359

merged 3 commits into from Nov 13, 2014

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Nov 12, 2014

According to Clang this package has 1 error and 84 warnings. The following patchset resolves the error and majority of warnings, only 2 warnings are left which are coming from a different package.

I have a feeling that most of problems are caused by copy & pasting the the code.

David Abdurachmanov added 3 commits November 12, 2014 16:43
Resolve unused variable 'SECS_PER_LUMI' error
22509f5 
Clang 3.5.0 complains regarding unused variable:

    DQM/HLTEvF/plugins/TriggerRatesMonitor.cc:44:21: error: unused variable
    'SECS_PER_LUMI' [-Werror,-Wunused-const-variable]

The patch removes it.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Resolve all -Wunused-private-field warnings
82c0ec2 
A vast number of warnings in `DQM/HLTEvF` are

    private field '???' is not used [-Wunused-private-field]

It looks like a mistake of copy & paste. The patch removes all such
not needed private fields.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
std::fabs ==> std::abs if argument is int
5ff99b2 
We have `std::vector<int>`, thus std::abs must be used from `<cstdlib>`.
Otherwise it triggers unnecessary conversion to `double`.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Nov 12, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_3_X.

Clean up DQM/HLTEvF based on Clang warnings/errors

It involves the following packages:

DQM/HLTEvF

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5ff99b2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6359/835/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6359/835/summary.html

@deguio
Copy link
Contributor

deguio commented Nov 13, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 13, 2014
@cmsbuild
Merge pull request #6359 from davidlt/clean-clang-DQM-HLTEvF
563d18a 
Clean up DQM/HLTEvF based on Clang warnings/errors
@cmsbuild cmsbuild merged commit 563d18a into cms-sw:CMSSW_7_3_X Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidlt @cmsbuild @deguio