Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vertex collection configurable in class computing MVA for non-isolated electrons. #6374

Merged
merged 4 commits into from Nov 14, 2014

Conversation

matteosan1
Copy link
Contributor

The MVA is now computed with the same vertex collection used in the electron producer (previously the collection name was hardcoded).
Additionally migrated one getByLabel to getByToken in the same class.
The change was esplicitly requested by HI people:
@yetkinyilmaz
@mandrenguyen
@istaslis

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_3_X.

Make vertex collection configurable in class computing MVA for non-isolated electrons.

It involves the following packages:

RecoEgamma/EgammaElectronProducers
RecoEgamma/ElectronIdentification

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 13, 2014

testing ... together with #6376

@slava77
Copy link
Contributor

slava77 commented Nov 14, 2014

+1

for #6374 dcb36c3
tested in CMSSW_7_3_X_2014-11-13-1400 (test area sign461).
No changes in regular reco quantities as expected.

A summary of changes in HI is to appear in #6376

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 14, 2014
Make vertex collection configurable in class computing MVA for non-isolated electrons.
@cmsbuild cmsbuild merged commit 57dcd16 into cms-sw:CMSSW_7_3_X Nov 14, 2014
@matteosan1 matteosan1 deleted the topic_SoftEleMVA branch May 28, 2015 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants